Skip to content

Job fails when scanning code with text blocks #21

@StruckCroissant

Description

@StruckCroissant

Recently I've had the Actions job fail due to extended SQL string blocks. See log & offending file below.

Actions job log printout:

/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:109:27: error: unclosed string literal
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:111:15: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:111:16: error: not a statement
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:111:19: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:112:15: error: not a statement
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:112:21: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:113:15: error: not a statement
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:113:20: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:1[14](https://github.com/StruckCroissant/Game-DB/runs/7166571439?check_suite_focus=true#step:3:16):[15](https://github.com/StruckCroissant/Game-DB/runs/7166571439?check_suite_focus=true#step:3:17): error: not a statement
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:114:31: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:115:15: error: not a statement
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:115:19: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:1[16](https://github.com/StruckCroissant/Game-DB/runs/7166571439?check_suite_focus=true#step:3:18):15: error: not a statement
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:116:26: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:1[17](https://github.com/StruckCroissant/Game-DB/runs/7166571439?check_suite_focus=true#step:3:19):15: error: not a statement
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:117:21: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:1[18](https://github.com/StruckCroissant/Game-DB/runs/7166571439?check_suite_focus=true#step:3:20):15: error: not a statement
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:118:27: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:1[19](https://github.com/StruckCroissant/Game-DB/runs/7166571439?check_suite_focus=true#step:3:21):15: error: not a statement
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:119:21: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:121:14: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:122:[20](https://github.com/StruckCroissant/Game-DB/runs/7166571439?check_suite_focus=true#step:3:22): error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:1[23](https://github.com/StruckCroissant/Game-DB/runs/7166571439?check_suite_focus=true#step:3:25):[24](https://github.com/StruckCroissant/Game-DB/runs/7166571439?check_suite_focus=true#step:3:26): error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:123:32: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:123:37: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:123:49: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:124:24: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:124:31: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:124:36: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:124:48: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:1[25](https://github.com/StruckCroissant/Game-DB/runs/7166571439?check_suite_focus=true#step:3:27):17: error: ';' expected
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:125:24: error: illegal start of expression
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:125:25: error: illegal start of expression
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:125:28: error: unclosed string literal
/home/runner/work/Game-DB/Game-DB/api/main/java/com/StruckCroissant/GameDB/core/user/UserDAOImpl.java:125:[26](https://github.com/StruckCroissant/Game-DB/runs/7166571439?check_suite_focus=true#step:3:28): error: not a statement
Error: Google Java Format failed with exit code 1

Lines from the file that the job is referencing:

@Override
  public List<Game> selectSavedGames(int uid) {
    final String sql = """
        SELECT
            g.gid,
            g.gname,
            g.cost,
            g.discounted_cost,
            g.url,
            g.age_rating,
            g.indie,
            g.description,
            g.rdate,
            g.rawgId
        FROM
            game g
            INNER JOIN plays p ON g.gid = p.gid
            INNER JOIN user u ON p.uid = u.uid
        WHERE u.uid = ?;""";
    return jdbcTemplate.query(sql, (resultSet, i) -> getGameFromResultSet(resultSet), uid);
  }

As you can see the multiline string assignment is messing with the Actions job. It looks like anything within the extended block is immediately treated as Java code. It would be nice to have the bot recognize the extended string block & automatically exclude it from the analysis.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions