Revert "Tighten substitution pattern for Fn::Sub (#842)"#858
Merged
JordonPhillips merged 1 commit intosmithy-lang:mainfrom Jul 12, 2021
Merged
Revert "Tighten substitution pattern for Fn::Sub (#842)"#858JordonPhillips merged 1 commit intosmithy-lang:mainfrom
JordonPhillips merged 1 commit intosmithy-lang:mainfrom
Conversation
This reverts commit fd5731f.
JordonPhillips
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fd5731f.
Description of changes:
#842 was made with the assumption that in the Smithy model, the strings that need Fn::Sub contain the final values as CloudFormation expects. It did not consider that those string could contain placeholder literals, like
<lambdaFunction>or{{REPLACEME}}that could be post-processed by something like the CDK to generate the values as CloudFormation expects.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.