Merged
Conversation
Member
|
Thanks! I moved the tests to the smithy-utils package since the issue can be reproduced there. I also fixed the bug. |
mtdowling
approved these changes
Oct 31, 2020
…(what I believe to be) a bug.
We were not writing intercepted sections that did not contain newlines.
mtdowling
force-pushed
the
write-inline-section-bug
branch
from
d72681a to
7512f16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inline test is failing due to (what I believe to be) a bug.
Issue #, if available: N/A
Description of changes:
I have code that requires multiple integrations to all contribute a string to the same line in codegen output. I use
CodeWriter.writeInLine()but this produces no change in the codegen output. This PR captures the bug.I've added another test which passes which exercises
CodeWriter.write()in addition to the breaking test.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.