Improve ISSM interface #1223
Merged
Improve ISSM interface #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
force-pushed
the
fix-issm-features
branch
from
2780b9e to
fe7a198
Compare
lostella
commented
Dec 16, 2020
lostella
added
the
BREAKING
lostella
force-pushed
the
fix-issm-features
branch
from
4912cda to
33921d4
Compare
rshyamsundar
previously approved these changes
Dec 21, 2020
lostella
dismissed
rshyamsundar’s stale review
tests are missing, and are pending the bugfix in #1233
lostella
force-pushed
the
fix-issm-features
branch
from
33921d4 to
e1c0939
Compare
test/model/deepstate/test_issm.py
Outdated
|
|
||
| season_indices = [[0] * 10, [0] * 2 + [1] * 8] | ||
|
|
||
| for item in range(1, 2): |
There was a problem hiding this comment.
You are checking here for only one item?
There was a problem hiding this comment.
right, that was for debugging, I'll revert it
| for item in range(1, 2): | ||
| for time in range(2, 10): | ||
| season_indicator = mx.nd.one_hot( | ||
| mx.nd.array([season_indices[item][time]]), 12 |
There was a problem hiding this comment.
Maybe I am missing something: mx.nd.array([season_indices[item][time]]) is always [1] for this range of item and time values and you always create this one_hot array: [[0. 1. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]]?
There was a problem hiding this comment.
on item=0 the season index is always 0, on item=1 the season index changes from 0 to 1 after two time steps
|
Also maybe can you run |
rshyamsundar
approved these changes
Dec 22, 2020
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: addresses #1200
Description of changes: Using custom ISSMs in DeepState (i.e. other than the default one for the given frequency), does not work because the time features from which coefficients are constructed always fall back to the default ones. This PR changes this, by coupling each ISSM with the time feature that is needed to derive its coefficients.
Tests are added for the ISSM classes, which were not there before.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.