Extend Platform Helper Functions #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
==========================================
- Coverage 84.32% 84.19% -0.13%
==========================================
Files 58 58
Lines 6078 6093 +15
==========================================
+ Hits 5125 5130 +5
- Misses 953 963 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TingDaoK
reviewed
Oct 20, 2025
Comment on lines
+82
to
+87
| AWS_STATIC_STRING_FROM_LITERAL(s_windows_str, "Windows"); | ||
| AWS_STATIC_STRING_FROM_LITERAL(s_macos_str, "macOS"); | ||
| AWS_STATIC_STRING_FROM_LITERAL(s_ios_str, "iOS"); | ||
| AWS_STATIC_STRING_FROM_LITERAL(s_android_str, "Android"); | ||
| AWS_STATIC_STRING_FROM_LITERAL(s_unix_str, "Unix"); | ||
| AWS_STATIC_STRING_FROM_LITERAL(s_unknown_str, "Unknown"); |
Contributor
There was a problem hiding this comment.
why do we pick these specific string, where will they be used for?
Maybe add a comment so that we have a source of truth for those hardcoded values
Contributor
Author
There was a problem hiding this comment.
Updated the comments to explain the enum and string representations.
TingDaoK
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, and/or reason for changes (REQUIRED):
Extend platform os help functions. This will be used for future metrics collection.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.