Fix Lliam deduplication issues. #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dedupe_reservoir was run, it was not accounting for title_abbrev fields that were already appended with a number. This change compares the field values without any appended numbers, and then appends a new number based on the count. Initially I wanted to just pick up where the count left off. However, it turned out to be possible to generate duplicate titles on subsequent runs, so there was no way to determine what the 'original' duplicate was.
cpyle0819
force-pushed
the
corepyle/lliam-run-08-14
branch
from
10e6cc4 to
ea39788
Compare
aws_doc_sdk_examples_tools/lliam/service_layer/dedupe_reservoir.py
Outdated
Show resolved
Hide resolved
Laren-AWS
approved these changes
Aug 18, 2025
DavidSouther
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
When dedupe_reservoir was run, it was not accounting for title_abbrev
fields that were already appended with a number. This change compares
the field values without any appended numbers, and then appends a new
number based on the count. Initially I wanted to just pick up where
the count left off. However, it turned out to be possible to generate
duplicate titles on subsequent runs, so there was no way to determine
what the 'original' duplicate was.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.