[Minor change] Avoid a NullPointerException... #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't do an early exit after line 30, line 36 (37 above) will throw an NPE... (Another way would be to throw new IOException(e) instead of printStacktrace)
|
Instead of returning without writing anything in the output stream, I would vote for re-throwing the exception. API Gateway by itself will return a 502 and Lambda will handle it by forcing another cold start of the container to give us a second chance ;) |
|
Hey @eranation, what do you think of my suggested change? Can you amend the pull request? |
|
I like it and will do!
… On Aug 12, 2017, at 10:43 PM, Stefano Buliani ***@***.***> wrote:
Hey @eranation, what do you think of my suggested change? Can you amend the pull request?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Somehow Travis refuses to run with this. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small and non critical suggestion...
Correct me if I'm wrong, but if we don't do an early exit after line 30 in the rare case of an exception, it will throw an NPE on line 36 (37 above)
Another way would be to throw new IOException(e) instead of printStacktrace
Great library by the way!