Created draft proof for s2n_constant_time_equals #2072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliperodri
suggested changes
Jul 1, 2020
tests/cbmc/proofs/s2n_safety_constant_time_equals/s2n_safety_constant_time_equals_harness.c
Outdated
Show resolved
Hide resolved
tests/cbmc/proofs/s2n_safety_constant_time_equals/s2n_safety_constant_time_equals_harness.c
Outdated
Show resolved
Hide resolved
tests/cbmc/proofs/s2n_safety_constant_time_equals/s2n_safety_constant_time_equals_harness.c
Outdated
Show resolved
Hide resolved
azcwagner
force-pushed
the
s2n_constant_time_equals_proof
branch
from
d180bb2 to
7611c02
Compare
feliperodri
suggested changes
Jul 2, 2020
tests/cbmc/proofs/s2n_safety_constant_time_equals/s2n_safety_constant_time_equals_harness.c
Outdated
Show resolved
Hide resolved
tests/cbmc/proofs/s2n_safety_constant_time_equals/s2n_safety_constant_time_equals_harness.c
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2072 +/- ##
=======================================
Coverage 80.40% 80.40%
=======================================
Files 233 233
Lines 17634 17635 +1
=======================================
+ Hits 14179 14180 +1
Misses 3455 3455 |
feliperodri
approved these changes
Jul 2, 2020
danielsn
approved these changes
Jul 7, 2020
| /* Check logical equivalence of s2n_constant_time_equals against element equality */ | ||
| if(s2n_constant_time_equals(a, b, len)) { | ||
| assert(__CPROVER_forall {size_t i; (i >=0 && i < len) ==> (a[i] == b[i])}); | ||
| } |
There was a problem hiding this comment.
We concluded that checking that it gets it right for inequality wasn't working, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that while we are transitioning from travis-ci to AWS CodeBuild, some tests are run on each platform. Non-AWS contributors will temporarily be unable to see CodeBuild results. We apologize for the inconvenience.
Resolved issues:
N/A
Description of changes:
Call-outs:
Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.