refactor(build): make cargotiming to build and test for workspace #2904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
related to #2903 and #2896.
Description of changes:
We have recently introduced
s2n-quic-dc-metricscrate which has a different MSRV than the other s2n-quic's crate. The cargotiming job seems to always use 1.84.0 as its rust version which caused compiling issue with thes2n-quic-dc-metricscrate. Hence, I am adding forcing the job to use the stable rust toolchain, so that it can run build and tests on all crates in the s2n-quic repository.Call-outs:
I am also adding the flag
--workspacefor the build phase, since we also want to measure build time to build dcQUIC.Testing:
I have ran the job on Codebuild and it is passing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.