Skip to content

Conversation

@boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Dec 1, 2025

Release Summary:

Resolved issues:

related to #2903 and #2896.

Description of changes:

We have recently introduced s2n-quic-dc-metrics crate which has a different MSRV than the other s2n-quic's crate. The cargotiming job seems to always use 1.84.0 as its rust version which caused compiling issue with the s2n-quic-dc-metrics crate. Hence, I am adding forcing the job to use the stable rust toolchain, so that it can run build and tests on all crates in the s2n-quic repository.

Call-outs:

I am also adding the flag --workspace for the build phase, since we also want to measure build time to build dcQUIC.

Testing:

I have ran the job on Codebuild and it is passing.

[Instance] <Time Stamp> Running command cargo build --workspace --timings --release
...
Compiling s2n-quic-dc-metrics v0.69.0
...
Compiling s2n-quic-dc v0.69.0
...
Compiling s2n-quic-dc-benches v0.1.0
...
[Instance] <Time Stamp> Running command cargo test --workspace
...

Running unittests src/lib.rs (target/debug/deps/s2n_quic_dc_metrics-60d8936f8de0643f)
--
 
running 22 tests
test appender::test::flush_on_drop ... ok
test appender::test::test_configured_rotation ... ok
test appender::test::test_reuse ... ok
test appender::test::test_rotation ... ok
test appender::test::test_time_rollback ... ok
test rseq::tests::check_per_cpu ... ok
test summary::bucket::tests::idx_to_upper_bound ... ok
test summary::bucket::tests::idx_to_lower_bound ... ok
test summary::bucket::tests::sizes ... ok
test rseq::tests::test_thread_ctor_dtor ... ok
test summary::bucket::tests::total_buckets ... ok
test summary::bucket::tests::value_to_idx ... ok
test summary::test::config ... ok
test test::counters_for_enum_counts ... ok
test summary::test::maximum ... ok
test counter::basic ... ok
test rseq::tests::test_send_event_local ... ok
test summary::test::count_correct ... ok
test rseq::tests::check_send_slow_branches ... ok
test summary::test::visits_all_buckets ... ok
test rseq::tests::test_send_event_overflow ... ok
test rseq::tests::check_send_branches ... ok
 
test result: ok. 22 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.12s


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@boquan-fang boquan-fang marked this pull request as ready for review December 1, 2025 18:45
@boquan-fang boquan-fang requested a review from a team as a code owner December 1, 2025 18:45
@boquan-fang boquan-fang requested review from dougch and jouho December 1, 2025 18:45
@boquan-fang boquan-fang merged commit 1ac1364 into aws:main Dec 1, 2025
122 checks passed
@boquan-fang boquan-fang deleted the cargotiming-fix branch December 1, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants