-
Notifications
You must be signed in to change notification settings - Fork 151
ci: Add a conv. commit lint action+config #2881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8262ab9 to
a1b6875
Compare
| extends: ['@commitlint/config-conventional'], | ||
| rules: { | ||
| 'subject-case': [0], | ||
| 'body-max-line-length': [0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we limit the maximum length for the subject: https://commitlint.js.org/reference/rules.html#subject-max-length? We probably shouldn't allow a PR subject to be larger than one line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's address in a followup, I'm not sure what the right value is here and don't want to guess low.
Co-authored-by: Boquan Fang <[email protected]>
0db242c to
3b637d2
Compare
ci: This reverts commit a243f2e.
ci: This reverts commit a243f2e.
ci: This reverts commit a243f2e.
ci: This reverts commit a243f2e.
Release Summary:
Description of changes:
GitHub Action to check the last commit for compliance with conventional commits.
Call-outs:
I've added a few types from the commit history to the config that aren't common:
optandinternal.Aiming for parity of the config with the https://github.com/aws/s2n-tls project.
Testing:
In this PR's history, you can see a force push that failed when I removed the
ci:prefix from the commit.local:
No output means the commit passed, but from the above output you can see that there are a few past commits that would have failed this check.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.