Skip to content

Conversation

@boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Oct 13, 2025

Release Summary:

  • extend the ring buffer unit tests to run against the shared testing message for all scenarios
  • teach the testing message to round-trip ECN values so the new send/recv check passes

Resolved issues:

This PR is derived from #2844. It was originally coded by @cnaples79.

This PR resolves #2809. Once this PR is merge in, it should also resolves #2844.

Description of changes:

On top of @cnaples79's PR, I have updated the snapshot for the PR so that it would pass the CI.

Call-outs:

Testing:

All CI should pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@boquan-fang boquan-fang marked this pull request as ready for review October 13, 2025 20:44
@boquan-fang boquan-fang requested a review from a team as a code owner October 13, 2025 20:44
@maddeleine maddeleine changed the title tests: exercise ring buffers with testing message tests: Includes integ test Message representation in ring buffer tests Oct 14, 2025
Copy link
Contributor

@maddeleine maddeleine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ECN values were previously getting discarded in our tests, which is reflected in the "ecn_state_changed.state|FAILED=1" line that is now removed in the snapshot tests.

@maddeleine maddeleine changed the title tests: Includes integ test Message representation in ring buffer tests tests: Include integ test Message representation in ring buffer tests Oct 14, 2025
@boquan-fang boquan-fang merged commit 73c9278 into aws:main Oct 14, 2025
192 of 194 checks passed
@boquan-fang boquan-fang deleted the fix-message-tests branch October 15, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests: Add testing::message::Message to ring.rs tests

3 participants