refactor(s2n-quic-tests): add test annotation to endpoint_limits_close_test #2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endpoint_limits_close_test
Mark-Simulacrum
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
related to #2792, #270
Description of changes:
I noticed that I didn't add the compliance test annotation to the
endpoint_limits_close_testfor RFC section 5.2.2. Hence, the compliance report is showingmissing testfor 5.2.2.This PR add the test annotation so that it adds that annotation.
Call-outs:
Testing:
We should see section 5.2.2 as complete in the compliance report.
https://dnglbrstg7yg.cloudfront.net/04c39cc0176b2350f83bc0cd432f694b27d8b05a/compliance.html#/spec/https%3A%2F%2Fwww.rfc-editor.org%2Frfc%2Frfc9000/section-5.2.2#A2072
That section is shown as
Completenow.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.