fix(s2n-events): Fix warning when no nominal counters are defined #2811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
force-pushed
the
no-nominal-counters
branch
from
7ec0faa to
3ab21e4
Compare
boquan-fang
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
An events system generated by s2n-events will currently emit a warning when the events system defines no nominal counter metrics. This is because
apiis imported innominal_counters()but is unused, since there are no nominal counter definitions.This PR ignores the unused_imports warning on this import, similar to other instances where an import is declared but may be unused.
Call outs:
The manual change is made in src/output/metrics/aggregate.rs (and the event struct update in events/connection.rs). The remaining changes are the resulting code generation.
Testing:
This PR removes the only nominal counter metric in the test events system. The clippy job which fails on warnings should no longer fail on this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.