generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 151
test(s2n-quic-dc): implement tokio stream tests for dcQUIC #2772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9bae9b1 to
979856a
Compare
Contributor
Author
|
NOTE:: #2774 already implement the |
Mark-Simulacrum
previously approved these changes
Aug 26, 2025
a582b32 to
c824293
Compare
seems like tracing::debug! doesn't show up. Use tracing::info! instead. REVERT THIS COMMIT ONCE IT IS NO LONGER NEEDED!
c824293 to
81b2b59
Compare
This reverts commit 81b2b59. The CI should only fail on multiple_shutdown_test: * I test that on my macOS and it is passing. Maybe the github action's MacOS runner is different?
* I want to see if this would pass the CI. * I suspect that Github MacOS is not having the same behavior as other macOS. * This change will most certainly needs to be reverted!
This reverts commit 406b5d8.
732987f to
7b2c7ba
Compare
daf98bc to
f8bd760
Compare
Mark-Simulacrum
approved these changes
Sep 15, 2025
This was referenced Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Description of changes:
This PR implements stream tokio tests for dcQUIC.
For testing purpose, I need to implement a
TestTlsProviderwhich implements thetls::Providertrait to use certs froms2n-quic-coreto perform handshake. Furthermore, since tests don't require a event subscriber to do anything, I implemented aNoopSubscriber, which implements theevent::SubscriberfromdcQUICands2n-quic-coiretraits to act as a test event subscriber. Those tests don't need a event query function to do anything, so I set up an emptyquery_eventfunction to act as a input to the tests as well.Tests that I implemented perform handshakes between dcQUIC endpoints using the client, server, and io providers from the psk directory.
Call-outs:
I was trying to write the
multiple_shutdown_test()like:I verifies that the
stream::tests::behavior::tcp::write::multiple_shutdown_testis working fine on my local Mac laptop. That is the expected behavior: when atokio TcpStreamwas shutdown on my Mac laptop, it won't allow us to shut it down again and will emit aNotConnectederror. However, the Github Action running onmacos-latestbehaves quite differently. Atokio TcpStreamcan be shutdown multiple times onmacos-latestgithub action runner. In that case, I decide to not running that test on macos. Refer to this run for more information.Testing:
All these tests should pass the CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.