ci: remove exceptions for clippy #2726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesleyRosenblum
changed the title
boquan-fang
approved these changes
Jul 23, 2025
|
|
||
| cargo +nightly fmt --all -- --check | ||
| cargo +stable clippy --all-features --all-targets -- -D warnings -A clippy::derive_partial_eq_without_eq -A clippy::manual_clamp -A clippy::uninlined_format_args | ||
| cargo +stable clippy --all-features --all-targets -- -D warnings |
Contributor
There was a problem hiding this comment.
Should we just add -- -D warnings option to
s2n-quic/.github/workflows/ci.yml
Lines 901 to 903 in 5855e53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR removes some exceptions for Clippy lints that have either been improved to reduce false positives, or can be fixed in code.
Testing:
Clippy passing in CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.