Skip to content

Conversation

@boquan-fang
Copy link
Contributor

Release Summary:

Resolved issues:

related to #2697

Description of changes:

In this PR, we introduced CloudFlare Quiche as a dev dependency. Our CargoTiming job is running on a EC2 fleet which doesn't have cmake installed. However, CloudFlare Quiche needs cmake to compile its TLS provider BoringSSL. Hence, we need to install cmake for the CargoTiming job.

Call-outs:

Testing:

I put this script into Codebuild, and manually kick off a CargoTiming job. Quiche finished compiling. The build can be found in this link.

Before this PR:

Compiling quiche v0.24.4


--- stderr
--
thread 'main' panicked at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.54/src/lib.rs:1119:5:
 
failed to execute command: No such file or directory (os error 2)
is `cmake` not installed?

After this PR:


Compiling s2n-tls-sys v0.3.22
--
Compiling openssl-sys v0.9.109
Compiling libmimalloc-sys v0.1.43
Compiling quiche v0.24.4
Compiling clap v4.5.41
Compiling matchers v0.1.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@boquan-fang boquan-fang requested review from dougch and maddeleine July 10, 2025 23:55
@boquan-fang boquan-fang requested a review from maddeleine July 14, 2025 18:19
@boquan-fang boquan-fang merged commit 467d164 into aws:main Jul 14, 2025
118 checks passed
@boquan-fang boquan-fang deleted the fix-cargotiming branch July 14, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants