ci: remove skipping tests for cargotiming #2680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Description of changes:
I made a change to remove skipping
ipv4_two_socket_test,ipv4_test, andmax_total_test. We were using the a docker image in our codebuildCargoTimingjob, but we have recently changed it to a EC2 fleet. The docker image doesn't allow endpoints to bind to a specific address, while the EC2 fleet does. Hence, we don't need to skip those three tests any more.Call-outs:
CargoTimingruns faster on EC2 fleet (It only takes 4 and a half minutes).Testing:
We have done a test that inline buildspec for this yml file:
and the test is passing: https://us-west-2.console.aws.amazon.com/codesuite/codebuild/003495580562/projects/CargoTiming/build/CargoTiming%3A211e6579-43ac-428c-92a6-65513a54b6e7/?region=us-west-2.
I will start another run against this PR: https://us-west-2.console.aws.amazon.com/codesuite/codebuild/003495580562/projects/CargoTiming/build/CargoTiming%3A9ad15b52-9e8b-4a24-ae18-4aae02afdaeb/?region=us-west-2
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.