Skip to content

Conversation

@boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Jun 20, 2025

Release Summary:

Resolved issues:

Description of changes:

I made a change to remove skipping ipv4_two_socket_test, ipv4_test, and max_total_test. We were using the a docker image in our codebuild CargoTiming job, but we have recently changed it to a EC2 fleet. The docker image doesn't allow endpoints to bind to a specific address, while the EC2 fleet does. Hence, we don't need to skip those three tests any more.

Call-outs:

  • This unblock one of our obstacles to add AL2023 support in our test. This was a problem mentioned in ci(test): create a al2023 test buildspec to support al2023 in CI #2657 (comment), but this PR will resolve that issue. Furthermore, the EC2 fleet by default is running on AL2023, so we just need to figure out how to incorporate that into our CI.
  • It seems like CargoTiming runs faster on EC2 fleet (It only takes 4 and a half minutes).

Testing:

We have done a test that inline buildspec for this yml file:

[Instance] 2025/06/20 21:19:37.387479 Running command cargo test --workspace
--
351 | Compiling proc-macro2 v1.0.95
352 | Compiling unicode-ident v1.0.18
353 | Compiling libc v0.2.174
354 | Compiling cfg-if v1.0.1
355 | Compiling autocfg v1.5.0
356 | Compiling zerocopy v0.8.26
357 | Compiling syn v1.0.109
358 | Compiling either v1.15.0

and the test is passing: https://us-west-2.console.aws.amazon.com/codesuite/codebuild/003495580562/projects/CargoTiming/build/CargoTiming%3A211e6579-43ac-428c-92a6-65513a54b6e7/?region=us-west-2.

I will start another run against this PR: https://us-west-2.console.aws.amazon.com/codesuite/codebuild/003495580562/projects/CargoTiming/build/CargoTiming%3A9ad15b52-9e8b-4a24-ae18-4aae02afdaeb/?region=us-west-2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@boquan-fang boquan-fang marked this pull request as ready for review June 20, 2025 21:46
@boquan-fang boquan-fang requested a review from jouho June 20, 2025 21:48
@boquan-fang boquan-fang enabled auto-merge (squash) June 20, 2025 21:51
@boquan-fang boquan-fang merged commit 32ba87d into aws:main Jun 20, 2025
117 checks passed
@boquan-fang boquan-fang deleted the delete-skip branch June 20, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants