Skip to content

fix(s2n-quic-dc): make TCP shutdown a no-op #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camshaft merged 1 commit into from
Dec 4, 2024
Merged

fix(s2n-quic-dc): make TCP shutdown a no-op #2402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions dc/s2n-quic-dc/src/stream/socket/fd/tcp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,3 @@ where
unsafe { libc::sendmsg(fd, &msg, flags) }
} as _)
}

#[inline]
pub fn shutdown<T>(fd: &T) -> io::Result<()>
where
T: AsRawFd,
{
libc_call(|| unsafe { libc::shutdown(fd.as_raw_fd(), libc::SHUT_WR) as _ })?;
Ok(())
}
4 changes: 2 additions & 2 deletions dc/s2n-quic-dc/src/stream/socket/tokio/tcp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ impl Socket for TcpStream {

#[inline]
fn send_finish(&self) -> io::Result<()> {
// AsyncWrite::poll_shutdown requires a `&mut self` so we just use libc directly
tcp::shutdown(self)
// Since we authenticate socket closures, no need to also shutdown the TCP layer
Ok(())
}
}
Loading