ci: undo cargo package ci task #2065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
#2009 added additional checks to the CI that ensure that the cargo package command succeeds on every PR. This was intended to catch build issues that a normal cargo build does not catch prior to publishing the crates. cargo package works by pulling dependencies (including those in the workspace) directly from crates.io, meaning that when changes are made in one crate that depend on another crate, the cargo package command may fail. Until we have a better solution that doesn't fail for this reason, this PR removes this additional check. I opened #2064 to follow up on this.
Call-outs:
I left the
detect-new-releasescript intact, as it could be useful in some other context.Testing:
CI
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed? -->
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.