refactor(s2n-quic-transport): move loss detection to core #2046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Nov 22, 2023
Contributor
camshaft
left a comment
camshaft
left a comment
There was a problem hiding this comment.
I like the approach. Very straightforward to reason about the algorithm when it's isolated like this 🙂
| //# detection [RFC5681] [RFC6675]. In order to remain similar to TCP, | ||
| //# implementations SHOULD NOT use a packet threshold less than 3; see | ||
| //# [RFC5681]. | ||
| pub const K_PACKET_THRESHOLD: u64 = 3; |
Contributor
There was a problem hiding this comment.
Would it be worth accepting this an a parameter, since this is just a default?
Contributor
Author
There was a problem hiding this comment.
Yeah I can do that, the time threshold is already a parameter so it makes sense
| largest_acked_packet_number: PacketNumber, | ||
| now: Timestamp, | ||
| ) -> Outcome { | ||
| debug_assert!(largest_acked_packet_number >= packet_number); |
Contributor
There was a problem hiding this comment.
Can you add a message to this so the caller knows what the expectation is?
camshaft
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change moves the detection of whether a packet should be considered lost or not to s2n_quic_core, for use in different contexts.
Call-outs:
There is a little bit of overlap in the tests between the new code and the
recovery::Manager, but for now I think its ok to ensure coverage until we have a better idea of how therecovery::Managerwill evolve.Testing:
Added some new tests
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed? -->
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.