fix: address clippy warnings for 1.74 #2035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-192
to
-197
| pub mod default { | ||
| #[cfg(not(unix))] | ||
| pub use super::rustls::*; | ||
| #[cfg(unix)] | ||
| pub use super::s2n_tls::*; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
yep. the new unused logic is a bit smarter to track private modules exporting pub but aren't actually used as part of the public interface.
Co-authored-by: Wesley Rosenblum <[email protected]>
WesleyRosenblum
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
A new stable rust release just went out and you know what that means: clippy fixes!
Testing:
The clippy task is now passing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.