refactor(s2n-quic-core): move PTO to core #2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/core-pto
branch
from
df6dba2 to
58c4057
Compare
WesleyRosenblum
approved these changes
Nov 10, 2023
| } | ||
| } | ||
|
|
||
| /// Manages the probe time out calculation and probe packet transmission |
Contributor
There was a problem hiding this comment.
recovery manager gets a little smaller 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In order to make it easier to test and use in alternative contexts, this change moves the PTO struct to the
s2n-quic-corecrate.Call-outs:
I also moved the
transmission::interestmodule tos2n-quic-coreto make it possible to have components in there that are able to transmit.Testing:
I moved the applicable recovery manager tests into the PTO module and refactored the recovery manager tests to only use the public interfaces.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.