fix(s2n-quic-core): minor fixes for perf and testing #2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /// Checks that the first argument is true, otherwise returns the second value | ||
| #[macro_export] | ||
| macro_rules! ensure { |
Contributor
There was a problem hiding this comment.
Do you think this naming makes sense for someone not familiar with the s2n-tls version? What about something like assert_or?
Contributor
Author
There was a problem hiding this comment.
So for s2n-tls I actually stole ENSURE and BAIL from macros in the rust ecosystem 😅
https://docs.rs/anyhow/latest/anyhow/macro.ensure.html
https://docs.rs/anyhow/latest/anyhow/macro.bail.html
https://docs.rs/failure/latest/failure/macro.ensure.html
https://docs.rs/failure/latest/failure/macro.bail.html
WesleyRosenblum
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I've been doing some experimentation with performance and made a few changes that didn't seem like they all warranted their own PR.
inlineto several functions that were missing it in the hot pathensure!macro that works similar to s2n-tls's ENSURE macros to make it easier to follow code (instead of saying "if not this, then return an error" it says "ensure this is true, otherwise return an error)TryFrom<VarInt> for {u8,u16,u32}By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.