refactor(s2n-quic-core): move ack::Ranges from transport #2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/ack-ranges
branch
from
a8fd60a to
31d678f
Compare
WesleyRosenblum
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change moves the ack::Ranges data structure from transport to core. This will make it easier to test and experiment with in different contexts.
Testing:
Since this is just a move from one crate to the other all of the tests have been moved along with it and should continue to pass.
Note that the
s2n-quic-transport packageCI check is failing since it downloads the s2n-quic-core from crates instead of using the local one. This will continue to fail until we do a new release (which may be something we need to fix in another PR).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.