Enable handle_get_set_test test in Kani via stubbing #2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add a stub for cmsg::decode where we return a non-deterministic AncillaryData object. With this stub, the handle_get_set_test harness terminates successfuly, since it doesn't include any assertions (that would be checked by Kani) over the content of the nondet object. Signed-off-by: Felipe R. Monteiro <[email protected]>
Signed-off-by: Felipe R. Monteiro <[email protected]>
camshaft
reviewed
Oct 26, 2023
| use s2n_quic_core::inet::AncillaryData; | ||
|
|
||
| pub fn decode(_msghdr: &libc::msghdr) -> AncillaryData { | ||
| let mut ancillary_data = AncillaryData::default(); |
Contributor
There was a problem hiding this comment.
Note to self: we talked offline about adding the ability to call any on a bolero generator. Ideally we would use that here to keep the generators consistent.
Signed-off-by: Felipe R. Monteiro <[email protected]>
camshaft
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A.
Description of changes:
We add a stub for cmsg::decode where we return a non-deterministic AncillaryData object. With this stub, the handle_get_set_test harness terminates successfuly, since it doesn't include any assertions (that would be checked by Kani) over the content of the nondet object.
Call-outs:
Verification time is less than a minute.
Testing:
N/A.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.