perf(s2n-quic-core): optimize varint encoding #2000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR focuses on improving varint encoding a bit by:
mov, rather than having to branch based on our integer size:s2n-quic/quic/s2n-quic-core/src/varint/table.rs
Lines 262 to 271 in b847852
I've also cleaned the code up a bit by moving the table functions into a separate module with an named struct, rather than a
(u64, usize, u64).Performance has improved by about 30-40%
Testing:
The existing tests should prevent any regressions in behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.