feat(s2n-quic-transport): add mitigation for optimistic ack attack #1986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
force-pushed
the
ak-ack_mitigation
branch
from
e77ff36 to
e8614d8
Compare
toidiu
force-pushed
the
ak-ack_mitigation
branch
2 times, most recently
from
99c6729 to
badc0bc
Compare
camshaft
reviewed
Oct 10, 2023
toidiu
force-pushed
the
ak-ack_mitigation
branch
from
badc0bc to
18e5347
Compare
toidiu
force-pushed
the
ak-ack_mitigation
branch
from
18e5347 to
8457b87
Compare
toidiu
force-pushed
the
ak-ack_mitigation
branch
from
a7e454a to
fd15fb9
Compare
camshaft
reviewed
Oct 11, 2023
| let client_subscriber = recorder::PacketSkipped::new(); | ||
| let client_events = server_subscriber.events(); | ||
| test(model, |handle| { | ||
| let mut server = Server::builder() |
Contributor
There was a problem hiding this comment.
Should we seed the random provider and assert an exact skip count? You could then run the test a few times with different seeds.
Contributor
There was a problem hiding this comment.
Speaking of: we need to set the seeds for all of the other tests since this PR introduces non-determinism
Contributor
Author
There was a problem hiding this comment.
Addressed here 31d8f0d
You could then run the test a few times with different seeds.
I tested with different seeds locally. Please let me know if I interpreted your suggestion incorrectly.
camshaft
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
#1962
Description of changes:
The RFC actually does a decent job of describing the issue:
This PR implements packet skipping for Opt Ack mitigation. I also added events to make this easier to test/introspect upon.
Callouts
I fixed a few new clippy lints in the PR.
Testing:
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed? -->
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.