fix(s2n-quic-transport): invoke on_packet_loss for all lost packets #1944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncongestioncontrolledonloss
…ngestioncontrolledonloss # Conflicts: # quic/s2n-quic-transport/src/recovery/manager.rs # quic/s2n-quic-transport/src/recovery/manager/tests.rs
camshaft
approved these changes
Aug 31, 2023
WesleyRosenblum
deleted the
WesleyRosenblum/noncongestioncontrolledonloss
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, if a transmitted packet was not congestion controlled (which is only
ACK+PADDINGpackets), we do not invoke theon_packet_lossmethod on the recovery context. This means that the AckManager is not notified of ACKs that are not bundled with other frames. This change fixes this so that all packets result in callingon_packet_losswhen lostTesting:
Added a fuzz test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.