feat(s2n-quic-tls): adds server session resumption functionality #1930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
changed the title
camshaft
previously approved these changes
Aug 28, 2023
Contributor
camshaft
left a comment
camshaft
left a comment
There was a problem hiding this comment.
This would ideally have the resumption tests enabled for the interop tests. But I'm fine to merge this and do that separate.
camshaft
reviewed
Aug 28, 2023
maddeleine
force-pushed
the
server_resumption
branch
from
520aa57 to
b84be9f
Compare
camshaft
reviewed
Aug 29, 2023
camshaft
previously approved these changes
Aug 30, 2023
camshaft
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A
Description of changes:
This PR introduces server-side session resumption. To get this working I transitioned the server tx_phase when the one RTT keys are created. This works because at that point the server has already sent its last handshake message (Server Finished.) I also added a CryptoStream to the ApplicationSpace so that Crypto frames can be sent there. Basically I just copied how the HandshakeSpace handles its CryptoStream.
Call-outs:
Session resumption is gated under the unstable_resumption flag. I manually tested that the server doesn't send tickets unless the flag is on.
Testing:
This PR includes an example of a server that can successfully do session resumption. I tested that that example can resume using a Quiche client since it already has client-side session resumption. If I need more tests please comment.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.