ci: require more interop tests to pass #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HandshakeLoss/Corruption tests succeeding
camshaft
reviewed
Aug 24, 2023
Comment on lines
+71
to
+75
| - "msquic": { | ||
| - "image": "ghcr.io/microsoft/msquic/qns:main", | ||
| - "url": "https://github.com/microsoft/msquic", | ||
| - "role": "both" | ||
| - }, |
Contributor
There was a problem hiding this comment.
I'm assuming this was intentional since they're always failing here. Would it be worth removing chrome and xquic as well? They haven't been working for some time.
Contributor
Author
There was a problem hiding this comment.
Yeah, I removed msquic because it was always failing but also it was taking a really long time to run (it was the longest of all the impls). chrome and xquic at least run relatively quickly. chrome was succeeding a while back, I'm not sure what happened. xquic does succeed on some tests. I think I would just leave those for now
camshaft
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change enforces that many more interop tests for CI to pass. This includes requiring tests for the s2n-quic client and s2n-quic-rustls to pass, which previously was not required for any testcase.
I fixed the
check.pyscript to correctly determine success for the s2n-quic client.Call-outs:
The ECN tests has not shown stability for the previous 50 runs (which is what the rest of the required checks are based on), but recent changes should hopefully resolve their instability
HandshakeLoss and HandshakeCorruption still don't seem stable enough to enable enforcement.Increasing timeouts to 5 minutes and disabling MTU probing to try to stabilize these
Rebind Address also has a timing issue that sometimes causes failures as well, so I haven't enabled that either.The rebind address test starts rebinding after 1 second, which in some cases is before the handshake has completed. Since connection migration is not permitted before the handshake has completed, this can cause the test to fail. To address this I have updated the quic-interop-runner patch to start the rebinding after 2 seconds.
Testing:
CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.