feat(s2n-quic-platform): support features override #1875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/platform-override
branch
2 times, most recently
from
bf1700f to
ead66c0
Compare
camshaft
force-pushed
the
camshaft/platform-override
branch
from
ead66c0 to
1b31d13
Compare
WesleyRosenblum
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #1850
Description of changes:
As discussed in the issue, it can be useful to override the platform features for a given build if your target environment is different than the build environment.
Testing:
I added a couple of CI jobs to test fewer features being enabled for Linux than what would be otherwise, to prevent something like #1849 in the future.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.