feat(s2n-quic-qns): add connection concurrency parameter #1870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic/s2n-quic-qns/src/client/h09.rs
Outdated
Comment on lines
39
to
41
| // `try_join_all` should be returning an Err if any stream fails, but it | ||
| // seems to just include the Err in the Vec of results. This will force | ||
| // any Error to bubble up so it can be printed in the output. |
Contributor
There was a problem hiding this comment.
comment needs updating
| #[structopt(long)] | ||
| connections: Option<usize>, | ||
|
|
||
| /// Defines the number of concurrent connections to open at any given time |
Contributor
There was a problem hiding this comment.
Can you add a comment on the connections option above to make it more clear how it differs from concurrency?
camshaft
force-pushed
the
camshaft/qns-concurrency
branch
from
e546484 to
a1f7820
Compare
WesleyRosenblum
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When using the qns application for testing, it can be useful to specify a limit for the total number of concurrent connections. This change allows for just that.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.