feat(s2n-quic-platform): Configurable buffer sizes + default tx buffer change #1859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cuts the default transmit buffer to 128kb, which reduces latencies when the network hardware cannot keep up with sending (or so is the current theory).
Collaborator
Author
|
I think test failures are spurious? |
Contributor
|
Yes most are unrelated. The only one we might need to look into is the arm test. The failures are coming from the integration test for the sockets which is in this path. |
Collaborator
Author
|
Mind retrying the test? I want to make sure it's not spurious before I go digging into setting up an Arm host. |
Contributor
|
So the arm test is run in a QEMU machine. I'm wondering if the more shallow buffers are causing it to take longer in this environment and the test bailing. So we may need to either increase the timeout or decrease the number of packets. |
In QEMU we see worse performance.
camshaft
approved these changes
Jul 5, 2023
camshaft
changed the title
kagarmoe
pushed a commit
that referenced
this pull request
Jul 27, 2023
…r change (#1859) * Support configuring internal tx/rx buffer sizes * Shrink transmit buffer default size This cuts the default transmit buffer to 128kb, which reduces latencies when the network hardware cannot keep up with sending (or so is the current theory). * Increase timeout for test In QEMU we see worse performance. * Cut to 30 packets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #1811
Description of changes:
This exposes new APIs for changing the internal send/receive buffers in the Tokio provider. It also changes the default transmit buffer to 128kb from 8mb, which on some hardware platforms significantly reduces latencies on one workload. (These are overheads from a baseline, which is why negatives can slip in, but should still be roughly comparable, as the baseline and runs with QUIC are the same workload).
Call-outs:
Not a huge fan of the name of these new methods, happy to change that.
Testing:
See latency figures above.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.