fix(s2n-quic-qns): use forked version of webpki #1837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
approved these changes
Jun 23, 2023
Contributor
camshaft
left a comment
camshaft
left a comment
There was a problem hiding this comment.
Seems reasonable to be, though it might be worth starting on the PR to webpki concurrently to upgrading to the latest rustls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
s2n-quic-rustlsis failing the anti amplification limit interop test because of a hard coded cert chain depth limit in thewebpkicrate thatrustlsuses, see #1836.This change introduces a patch to the top level
Cargo.tomlthat is applied as part of running interop that will swap out the version ofwebpkifor a forked version that increases the cert chain depth limit.Testing:
Tested locally and in CI. s2n-quic-rustls amplification limit test passes now: https://dnglbrstg7yg.cloudfront.net/bd8f2ce325ade00fee3d6cb77aefe58483081155/interop/index.html?client=s2n-quic-pr1837,s2n-quic-rustls&server=s2n-quic,s2n-quic-pr1837,s2n-quic-rustls&test=a
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.