refactor(s2n-quic-xdp): simplify the IO implementations #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/xdp-io-simplify
branch
2 times, most recently
from
a7ff46c to
598b0ed
Compare
|
|
||
| type Fd = tokio::io::unix::AsyncFd<socket::Fd>; | ||
|
|
||
| /// Polls read readiness for a tokio socket |
Contributor
There was a problem hiding this comment.
Can you put a comment on what this returns
Comment on lines
+23
to
+29
| let _ = tx; | ||
| let _ = completion; | ||
| let _ = cx; |
Contributor
There was a problem hiding this comment.
why is this necessary?
Contributor
Author
There was a problem hiding this comment.
I'll add a comment
camshaft
force-pushed
the
camshaft/xdp-io-simplify
branch
from
598b0ed to
f0dba55
Compare
WesleyRosenblum
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
After experimenting with our AF_XDP implementation in #1765, I noticed some latency coming from having to register and wake the XDP tasks and wondered if the implementation could be simplified a bit to operate on the rings directly in the IO channels.
I ended up with this change, which is much simpler than what was there. I was able to remove the use of the
spscchannel, which definitely added to the complicated code, since you're having to manage backpressure on 4 channels instead of 2. Removing it also reduces the need to copy the descriptors as much.Testing:
The IO tests have been updated to use the new implementations. I've also done some testing in the mentioned branch and things look more stable as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.