feat(s2n-quic-core): add slice::zip function #1824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
While implementing the XDP functionality, I needed a way to zip up slices of slices and iterate over each item. This could be accomplished with
head.iter().chain(tail).zip(head2.iter_mut().chain(tail2)). However, this is a bit slow and we already have an optimized slices of slices iterator invectored_copy.This change refactors the
vectored_copyiteration functionality into a separatezip_chunksfunction. This function accepts a callback for each pair of overlapping slices. Thevectored_copyfunction now uses this to implement the copy. I've also added a simplezipfunction which operates on single items.Testing:
The bolero/kani tests for the vectored_copy should verify all of the safety in the underlying function.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.