Vectored write for datagrams #1809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets callers who have "headers" associated with each datagram in separate buffers avoid needing to copy into a buffer just for the write call (which results in another copy into the destination).
camshaft
approved these changes
Jun 13, 2023
Mark-Simulacrum
force-pushed
the
vectored-datagram-write
branch
from
123ff1d to
bc3742d
Compare
Collaborator
Author
|
(Squashed commits, no changes) |
camshaft
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This lets callers who have "headers" associated with each datagram in separate buffers avoid needing to copy into a buffer just for the write call (which results in another copy into the destination).
No intended functional changes, only more efficient callers.
Callouts
The EncoderValue implementation for slices isn't using the s2n-quic-core vectored copy implementation - it seems like that would require a new write_vectored_slice or similar. Open to writing that but maybe I missed some implementation that already exists and I can just call into.
Testing:
No tests added - I was looking for some UDP datagram tests but nothing seems to call write_datagram today? So I assume this works.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.