fix(s2n-quic-core): update rtt sampling logic based on an errata for RFC9002 #1805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
254
to
255
| //# | ||
| //# this logic has been updated to follow the errata reported in https://www.rfc-editor.org/errata/eid7539 |
Contributor
There was a problem hiding this comment.
The //# is specifically for RFC compliance comments that get parsed by the Duvet tool, so this line should just use regular // syntax on a separate line
Suggested change
| //# | |
| //# this logic has been updated to follow the errata reported in https://www.rfc-editor.org/errata/eid7539 | |
| // this logic has been updated to follow the errata reported in https://www.rfc-editor.org/errata/eid7539 |
Contributor
Author
There was a problem hiding this comment.
OK. I will update the code.
| context.path_mut().rtt_estimator.update_rtt( | ||
| Duration::from_millis(10), | ||
| Duration::from_millis(700), | ||
| Duration::from_millis(600), |
Contributor
There was a problem hiding this comment.
Why did this need to change?
Contributor
Author
There was a problem hiding this comment.
As the logic of the RTT calculation has been changed, there are some minor updates on testing results for checking the logic. Some variables such as persistent_congestion_threshold become slightly bigger. I think this change can suppress the errors in tests due to this small inflation.
WesleyRosenblum
changed the title
WesleyRosenblum
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
An errata for RFC9002 has been reported in https://www.rfc-editor.org/errata/eid7539
Related discussions can be found in https://mailarchive.ietf.org/arch/msg/quic/Y_NDekpArDyXniaTnjzG4ccePbA/
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.