refactor(s2n-quic-platform): use generic event loop for turmoil #1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/turmoil-upgrade
branch
3 times, most recently
from
41d79d4 to
8439b3d
Compare
jmayclin
reviewed
Jun 15, 2023
|
|
||
| tokio::spawn(run_io(socket, rx_producer, tx_consumer)); | ||
|
|
||
| let el = EventLoop { |
Contributor
There was a problem hiding this comment.
nit: el feels a bit dense even though it has a super-local scope. Primarily because it makes me think of the el rune from Diablo II rather than "event loop", but perhaps others who didn't play Diablo II so much wouldn't have that problem 😅
Contributor
Author
There was a problem hiding this comment.
you say that like it's a bad thing 😄
jmayclin
reviewed
Jun 15, 2023
camshaft
force-pushed
the
camshaft/turmoil-upgrade
branch
from
8439b3d to
d41686f
Compare
jmayclin
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We finally have enough PRs merged to use the generic event loop for the turmoil IO provider.
Call-outs:
Since the current turmoil API doesn't allow splitting the sockets, we still need a smaller event loop to both send and receive on the socket.
Testing:
The existing turmoil tests should be sufficient.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.