Skip to content

chore: run benchmarks in separate VMs #3622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2022
Merged

chore: run benchmarks in separate VMs #3622

merged 3 commits into from
Jun 27, 2022

Conversation

RomainMuller
Copy link
Contributor

The idea is to try and achieve a situation where iteration
times are not tainted by different memory situations (caches
may cause memory pressure and will skew the benchmark results).

Running in node sub-processes should allow removing this unknown
from the picture.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 27, 2022
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2022

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jun 27, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2022

Merging (with squash)...

@mergify mergify bot merged commit 5b8466a into main Jun 27, 2022
@mergify mergify bot deleted the rmuller/bench-in-sub-vm branch June 27, 2022 18:34
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2022

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants