adding guardrails for s3 buckets in different accounts #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
If two s3 buckets had the prefix "podid" in different regions, this would cause the tests to fail with the error:
getting bucket tagging: operation error S3: GetBucketTagging, https response error StatusCode: 301, RequestID: WGBQJQFB7Z2KXSVT, HostID: GAVWfFhWLvjhbykCzTgV3mIrOFU4lEAFVitSA8FMMavPLFcSPaVmBjHQ1B6a+ckL+SMvN+S/zHU=, api error PermanentRedirect: The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint.
Check if the bucket region is in a different region than the stack user is working on. If so, skip adding this to the list of s3 buckets to be deleted upon cleanup.
Testing (if applicable):
Ran make e2e-test ginkgo && ./_bin/e2e-test run-e2e -f="al23-amd64 && simpleflow && ssm" --skip-cleanup=true --artifacts-dir=e2e-artifacts --logs-bucket=
saw that error went away and expected infra was deployed in dev account. Was now able to run the tests in us-east-1 and us-west-2
Documentation added/planned (if applicable):
n/a
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.