-
Notifications
You must be signed in to change notification settings - Fork 160
fix(core): serialize bigint in metadata to string #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -332,6 +332,12 @@ describe('Subsegment', function() { | |
child.flush(); | ||
emitStub.should.have.been.called; | ||
}); | ||
|
||
it('should stringify bigint objects correctly', function() { | ||
child.addMetadata('key', BigInt(9007199254740991)); | ||
child.flush(); | ||
emitStub.should.have.been.calledOnce; | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd like to see a similar test for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The existing test harness for Segment stops at mocking the Adding this test would mean rearchitecting the tests and requires knowledge of the codebase that I don't have. If the maintainers want to add this, I'd suggest them to either: 1/ address this in a future PR, 2/ contribute to this PR and provide the test fixture. |
||
}); | ||
|
||
describe('#streamSubsegments', function() { | ||
|
Uh oh!
There was an error while loading. Please reload this page.