Skip to content

Conversation

@chungjac
Copy link
Contributor

@chungjac chungjac commented Dec 5, 2025

Description

The toolkit_didLoadModule metric was previously commented out (#5560) as there were issues with it. In present day, we are not aware of what these issues are.

I have sandboxed tested the login metric flow. It works as I would expect and did not see any apparent issues

Thus, reenabling the toolkit_didLoadModule metric by reverting #5560

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac marked this pull request as ready for review December 5, 2025 18:32
@chungjac chungjac requested a review from a team as a code owner December 5, 2025 18:32
Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why did we revert/commented out at the first place? any solid reason?

@chungjac chungjac merged commit c33256c into aws:main Dec 5, 2025
14 of 15 checks passed
@chungjac
Copy link
Contributor Author

chungjac commented Dec 5, 2025

Just curious why did we revert/commented out at the first place? any solid reason?

Unfortunately no. Our team is not aware of why it was commented out in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants