Skip to content

Add CBOR feature id and include it for operations called using CBOR Protocol #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025

Conversation

muhammad-othman
Copy link
Member

Description

This PR introduces support for tracking CBOR Protocol usage through PROTOCOL_RPC_V2_CBOR User Agent feature ID:

Motivation and Context

DOTNET-8159

Testing

  • Tested the changes with a CBOR operation and validated that the proper feature id was added to the user agent header.
  • DRY_RUN-f0b905a7-cf3c-4840-a279-54c788b90e89.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@muhammad-othman muhammad-othman merged commit e82f8e5 into cbor-protocol Jul 30, 2025
1 check passed
@muhammad-othman muhammad-othman deleted the muhamoth/DOTNET-7384-cbor-featureid branch July 30, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants