fix(client-s3-control): remove host prefix behavior #7025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
changed the title
siddsriv
approved these changes
Apr 24, 2025
kuhe
reviewed
Apr 24, 2025
| headers: { | ||
| host: "123456789012.s3-outposts.us-west-2.amazonaws.com", |
There was a problem hiding this comment.
- open question as to whether this is intended 🚧
There was a problem hiding this comment.
I received confirmation that this change is ok.
trivikr
approved these changes
Apr 24, 2025
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
S3 and S3 control, when using endpointRuleSet trait, should ignore the endpoint+hostPrefix traits. This adds model preprocessing to remove those traits.
This is a customization for S3 and S3 Control.
Testing
Attached the endpoints 2.0 suite to integration test group.
I tried to refactor the tests to use clients instead of just the endpoint resolver, but the complexity was too high. Attempt it later.