Skip to content

fix(core): use credentials provided by extensions when instantiating sigv4 signer #6956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Mar 21, 2025

addresses #6954

requires smithy-lang/smithy-typescript#1548

allow the sigV4ConfigResolver to access the client and its resolved credentialsProvider when instantiating request signers

  • smithy hash update
  • needs full codegen

@kuhe kuhe requested a review from a team as a code owner March 21, 2025 01:12
@trivikr
Copy link
Member

trivikr commented Mar 21, 2025

Verified that the changes from this PR fix issue reported in #6954

@kuhe kuhe marked this pull request as draft March 21, 2025 15:52
@kuhe kuhe marked this pull request as ready for review March 21, 2025 16:35
@kuhe kuhe changed the title fix(core): sigv4ConfigResolver access client creds to instantiate signer fix(core): use credentials provided by extensions when instantiating sigv4 signer Mar 21, 2025
@kuhe kuhe merged commit 6288dff into aws:main Mar 21, 2025
4 checks passed
@kuhe kuhe deleted the fix/extensions branch March 21, 2025 17:32
kuhe added a commit to kuhe/aws-sdk-js-v3 that referenced this pull request Mar 21, 2025
kuhe added a commit that referenced this pull request Mar 21, 2025
Copy link

github-actions bot commented Apr 5, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants