Skip to content

chore(deps): bump fast-xml-parser to 4.1.2 #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 21, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 21, 2023

Issue

https://security.snyk.io/vuln/SNYK-JS-FASTXMLPARSER-3325616

Description

Bump fast-xml-parser to 4.1.2

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore(deps-dev): bump fast-xml-parser to 4.1.2 chore(dev): bump fast-xml-parser to 4.1.2 Feb 21, 2023
@trivikr trivikr changed the title chore(dev): bump fast-xml-parser to 4.1.2 chore(deps): bump fast-xml-parser to 4.1.2 Feb 21, 2023
@trivikr
Copy link
Member Author

trivikr commented Feb 21, 2023

The codegen-ci failure is due to fast-xml-parser version mismatch from smithy-typescript.

Equivalent PR is posted at smithy-lang/smithy-typescript#697, and verified that codegen-ci is successful in local workspace.

@trivikr trivikr marked this pull request as ready for review February 21, 2023 16:09
@trivikr trivikr requested a review from a team as a code owner February 21, 2023 16:09
@trivikr
Copy link
Member Author

trivikr commented Feb 21, 2023

Verified that integration tests are successful:

$ yarn test:integration:legacy
...
147 scenarios (147 passed)
488 steps (488 passed)
1m14.794s (executing steps: 1m13.686s)
Done in 76.67s.

@trivikr trivikr merged commit eb90ecc into aws:main Feb 21, 2023
@trivikr trivikr deleted the bump-fast-xml-parser branch February 21, 2023 16:29
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants