Skip to content

fix(client-s3): add staticContextParams in endpoint param instructions #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trivikr merged 4 commits into from
Dec 14, 2022
Merged

fix(client-s3): add staticContextParams in endpoint param instructions #4285

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ed82c6
fix(client-s3): add staticContextParams in endpoint param
trivikr Dec 14, 2022
6c023ab
fix(codegen): remove writeGetObjectResponseEndpointMiddleware
trivikr Dec 14, 2022
bc655df
fix(client-s3): remove writeGetObjectResponseEndpointMiddleware
trivikr Dec 14, 2022
85fc131
chore(middleware-sdk-s3): remove writeGetObjectResponseEndpointMiddle…
trivikr Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clients/client-s3/src/commands/CreateBucketCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ export class CreateBucketCommand extends $Command<

public static getEndpointParameterInstructions(): EndpointParameterInstructions {
return {
DisableAccessPoints: { type: "staticContextParams", value: true },
Bucket: { type: "contextParams", name: "Bucket" },
ForcePathStyle: { type: "clientContextParams", name: "forcePathStyle" },
UseArnRegion: { type: "clientContextParams", name: "useArnRegion" },
Expand Down
1 change: 1 addition & 0 deletions clients/client-s3/src/commands/WriteGetObjectResponseCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ export class WriteGetObjectResponseCommand extends $Command<

public static getEndpointParameterInstructions(): EndpointParameterInstructions {
return {
UseObjectLambdaEndpoint: { type: "staticContextParams", value: true },
ForcePathStyle: { type: "clientContextParams", name: "forcePathStyle" },
UseArnRegion: { type: "clientContextParams", name: "useArnRegion" },
DisableMultiRegionAccessPoints: { type: "clientContextParams", name: "disableMultiregionAccessPoints" },
Expand Down