fix(cloudfront-signer): accept passphrase when signing#4232
Merged
fix(cloudfront-signer): accept passphrase when signing#4232
Conversation
…se is reuiqred...'
trivikr
requested changes
Dec 2, 2022
trivikr
changed the title
3 tasks
unchaptered
commented
Dec 10, 2022
Contributor
Author
unchaptered
left a comment
unchaptered
left a comment
There was a problem hiding this comment.
Sorry to late response.
Maybe, I don't know if I understand open source culture properly.
After chang codes as your requests, am I commit it with mesion to you?
trivikr
approved these changes
Dec 12, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSIgnedUrl need new params of passphrase of RSA Key.
Issue
Description
Add new params of passphrase to fix issue.
Testing
Add new sample of passpharse to fix issue.
But, in testcode, aws have string type of privateKey.
So, I sugggest new privateKey and passphrase from AWS officials.
Additional context
Please consider its.
Now, getSignedUrl isn't working...