chore(clients): regenerate based on smithy-typescript#548#3634
Closed
gosar wants to merge 1 commit intoaws:directed-codegenfrom
Closed
chore(clients): regenerate based on smithy-typescript#548#3634gosar wants to merge 1 commit intoaws:directed-codegenfrom
gosar wants to merge 1 commit intoaws:directed-codegenfrom
Conversation
gosar
force-pushed
the
smithy-typescript-548
branch
2 times, most recently
from
7340812 to
3c609a6
Compare
gosar
force-pushed
the
smithy-typescript-548
branch
2 times, most recently
from
822befa to
2e90f17
Compare
gosar
force-pushed
the
smithy-typescript-548
branch
from
2e90f17 to
1eed05e
Compare
gosar
force-pushed
the
smithy-typescript-548
branch
from
1eed05e to
53389d1
Compare
Contributor
Author
|
With smithy-lang/smithy#1289, there are no longer any diffs in the generated clients based on smithy-lang/smithy-typescript#548, so closing this PR. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is against base branch of
directed-codegenwhich was created frommainon Jun 18 2022.Based on smithy-lang/smithy-typescript#548
Ran
yarn generate-clients && yarn test:protocols && yarn generate-clients -s && yarn test:server-protocolsand these are the diffs:Some protocol tests package.json had- This was fixed with commit in Use DirectedCodegen smithy-lang/smithy-typescript#548 which added support for protocol test generation via DirectedCodegen."@aws-sdk/querystring-builder": "*"removed from dependencylib-dynamodb is broken - has additional- This is fixed with Remove unnecessary src folder prepend in useShapeWriter smithy-lang/smithy-typescript#551../in imports making it incorrect and broken. This will need to be fixed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.